taproot-manufacturing/entomologist
2
0
Fork 0
Code Issues 1 Pull requests 2 Projects Releases Packages Wiki Activity Actions

completed Issues now know when they were marked Done #24

Merged
seb merged 6 commits from done-time into main 2025-07-18 10:21:44 -06:00
Conversation 0 Commits 6 Files changed 6 +277 -128
seb commented 2025-07-16 22:07:40 -06:00
Owner
Copy link

Several changes in this PR:

  • ent list FILTER: filter format changed, instead of a single String containing chunks separated by :, it's now a bunch of Strings, as many as you want, each containing one chunk
  • Issue::timestamp renamed to Issue::creation_time because there will be more timestamps for different things
  • Issue gained a new field, done_time, which gets set when the Issue state is set to Done. Can be overridden by ent done-time ISSUE TIMESTAMP.
  • ent list FILTER can now filter by done-time=[START]..[END]. START and END are in RFC 3339 format which is precise but not super ergonomic.
  • Minor code cleanup/refactor in issue.rs related to how commits are made.
Several changes in this PR: * `ent list FILTER`: filter format changed, instead of a single String containing chunks separated by `:`, it's now a bunch of Strings, as many as you want, each containing one chunk * `Issue::timestamp` renamed to `Issue::creation_time` because there will be more timestamps for different things * Issue gained a new field, `done_time`, which gets set when the Issue state is set to `Done`. Can be overridden by `ent done-time ISSUE TIMESTAMP`. * `ent list FILTER` can now filter by `done-time=[START]..[END]`. START and END are in RFC 3339 format which is precise but not super ergonomic. * Minor code cleanup/refactor in issue.rs related to how commits are made.
seb added 6 commits 2025-07-16 22:07:41 -06:00 
This improves code reuse and streamlines the code a bit.
This is instead of a single big string with chunks separated by ":".

":" is used in RFC 3339 date-time strings (like "2025-07-16 21:23:44
-06:00"), so it's inconvenient to reserve ":" to be the chunk separator.

I'm not super wedded to this new Vec<String> way of doing the filter,
but it seems fine and convenient for now.
This is to make room for a second timestamp that records when the issue
was marked Done.
This records the DateTime that the issue moved to the Done state (if any).
seb merged commit 04b33eb70f into main 2025-07-18 10:21:44 -06:00
seb deleted branch done-time 2025-07-18 10:21:45 -06:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: taproot-manufacturing/entomologist#24
No description provided.
Delete branch "done-time"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?