taproot-manufacturing/entomologist
2
0
Fork 0
Code Issues 1 Pull requests 2 Projects Releases Packages Wiki Activity Actions

skip unparsable issues #26

Merged
seb merged 4 commits from skip-unparsable-issues into main 2025-07-19 20:28:38 -06:00
Conversation 0 Commits 4 Files changed 4 +136 -74
seb commented 2025-07-19 10:42:09 -06:00
Owner
Copy link

This teaches Issues::new_from_dir() to skip over issues that fail to parse, but continue and read the other issues. Also prints a warning to the user about any unparsable Issue.

Replaces every unwrap() calls in the Issue and Comment api with a returned error.

Replaces most unwrap() calls in the git module with returned errors. Some unwraps still linger.

This teaches `Issues::new_from_dir()` to skip over issues that fail to parse, but continue and read the other issues. Also prints a warning to the user about any unparsable Issue. Replaces every `unwrap()` calls in the Issue and Comment api with a returned error. Replaces most `unwrap()` calls in the `git` module with returned errors. Some unwraps still linger.
seb added 3 commits 2025-07-19 10:42:10 -06:00 
Make and return errors instead.
This lets us at least handle the other, valid issues, while informing
the user about the ones we don't understand.
This replaces a bunch of `unwrap()` calls with error returns.
seb added 1 commit 2025-07-19 10:52:43 -06:00
seb merged commit 6a1e438c94 into main 2025-07-19 20:28:38 -06:00
seb deleted branch skip-unparsable-issues 2025-07-19 20:28:38 -06:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: taproot-manufacturing/entomologist#26
No description provided.
Delete branch "skip-unparsable-issues"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?