taproot-manufacturing/entomologist
2
0
Fork 0
Code Issues 1 Pull requests 2 Projects Releases Packages Wiki Activity Actions

cleanups-and-show-log-in-ent-sync #17

Merged
seb merged 5 commits from cleanups-and-show-log-in-ent-sync into main 2025-07-11 20:28:58 -06:00
Conversation 0 Commits 5 Files changed 4 +318 -137
seb commented 2025-07-11 13:15:41 -06:00
Owner
Copy link

Lots of refactoring and cleanups in this one. Tidying the API to enable better git commit messages.

ent sync now shows what it fetched, and what it will push. It's just a raw git log, so plenty of room for improvement there, but it's a start.

Lots of refactoring and cleanups in this one. Tidying the API to enable better git commit messages. `ent sync` now shows what it fetched, and what it will push. It's just a raw git log, so plenty of room for improvement there, but it's a start.
seb added 5 commits 2025-07-11 13:15:42 -06:00 
This starts cleaning up the Issue API.

* Start separating the public API from the internal API.

* Make `Issue::new()` and `Issue::edit_description()` better behaved,
  simpler, reduce code duplication, and also produce better git log
  messages.

* Update `ent` to call the changed `new()` function.

* Add some comments documenting the Issue API.

* `ent new` and `ent edit` now use the editor specified by the EDITOR
  environment variable, if any.  Defaults to `vi` if unspecified.
Instead of a two-step process handled by the application
(`Issue::new_comment()` and `Comment::set_description()` or
`Comment::edit_description()`), make a simpler-to-use single-step
`Issue::add_comment()`.

Move the implementation details from Issue to Comment.

Better log message when adding a comment.
seb merged commit 928e592722 into main 2025-07-11 20:28:58 -06:00
seb deleted branch cleanups-and-show-log-in-ent-sync 2025-07-11 20:28:59 -06:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: taproot-manufacturing/entomologist#17
No description provided.
Delete branch "cleanups-and-show-log-in-ent-sync"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?